Skip to content

cleanup#145

Open
p-hoffmann wants to merge 9 commits intomainfrom
p-hoffmann/cleanup
Open

cleanup#145
p-hoffmann wants to merge 9 commits intomainfrom
p-hoffmann/cleanup

Conversation

@p-hoffmann
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 25, 2026 23:59
@p-hoffmann p-hoffmann changed the base branch from main to develop March 26, 2026 00:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to be a cleanup that removes the Trex-related extension crates and associated assets from the workspace, and adjusts base crate feature defaults accordingly.

Changes:

  • Removed the ext/trexas DuckDB extension crate and its supporting Rust/TS assets.
  • Removed the ext/trex (trex_core) crate and its JS/Rust implementation.
  • Updated workspace membership and adjusted crates/base feature/dependency configuration around the Trex feature.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ext/trexas/src/trex_server.rs Deleted Trex server manager/config implementation.
ext/trexas/src/lib.rs Deleted DuckDB loadable extension entrypoint and scalar/table functions.
ext/trexas/src/bundle.rs Deleted bundling helper implementation.
ext/trexas/package.json Deleted extension packaging metadata/scripts.
ext/trexas/main/registry/template.json Deleted mock registry template.
ext/trexas/main/registry/registry-handler.ts Deleted mock registry request handler.
ext/trexas/main/registry/mod.ts Deleted registry module entrypoint.
ext/trexas/main/registry/mock.ts Deleted embedded mock package payload.
ext/trexas/main/index.ts Deleted main worker server sample.
ext/trexas/event-worker/index.ts Deleted event worker sample.
ext/trexas/Makefile Deleted extension build Makefile.
ext/trexas/Cargo.toml Deleted trexas crate manifest.
ext/trexas/.npmignore Deleted npm ignore rules.
ext/trexas/.gitignore Deleted crate-local gitignore.
ext/trex/test.ts Deleted a TS test script.
ext/trex/query_executor.rs Deleted query executor implementation.
ext/trex/lib.rs Deleted trex_core Rust implementation and tests.
ext/trex/js/trex_lib.js Deleted trex JS bindings.
ext/trex/js/dbconnection.js Deleted JS DB connection helpers.
ext/trex/connection.rs Deleted connection management code.
ext/trex/LICENSE Deleted license file for removed crate.
ext/trex/Cargo.toml Deleted trex_core crate manifest.
crates/base/Cargo.toml Changed trex_core dependency specification and base default features.
Cargo.toml Removed ext/trex and ext/trexas from workspace members and removed workspace dep entry for trex_core.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-hoffmann p-hoffmann changed the base branch from develop to main March 26, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants