Skip to content

Add concurrent to sentences and more#359

Open
sgelbart wants to merge 7 commits intomainfrom
ab-add-concurrent-to-sentences2
Open

Add concurrent to sentences and more#359
sgelbart wants to merge 7 commits intomainfrom
ab-add-concurrent-to-sentences2

Conversation

@sgelbart
Copy link
Copy Markdown
Collaborator

No description provided.


def self.prefix
'cd'
'cdf'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this wrong (just would have refreshed any starting with 'cd' too)

@@ -0,0 +1,287 @@
-- ============================================================
Copy link
Copy Markdown
Collaborator Author

@sgelbart sgelbart Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the changes and renames on these files actually made them not have good diffs with the originals in the end (not a big deal but nice to preserve when we can, which is what I was saying with the v2)

-- Unchanged from original version essentially.
-- ============================================================
-- refresh materialized view roster.cdf01_convicted_deferred_events_clean; -- 44s
-- drop materialized view roster.cdf01_convicted_deferred_events_clean;
Copy link
Copy Markdown
Collaborator Author

@sgelbart sgelbart Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always put a DROP statement here (for easy access plus to make tests work)
that goes for all the views

Comment thread spec/services/elt/sentencing_spec.rb Outdated
'JUDGE SHAW: DEFT APPEARS IN CUSTODY WITH COUNSEL TATE WISE. THE STATE IS PRESENT BY ADA
REBECCA HILL. THE DEFT ENTERS A PLEA OF GUILTY AND IS SENTENCED TO 4 YRS S/S. DEFT IS TO BE SUPERVISED BY DOC. THE DEFT
IS TO PAY COURT COSTS. ALL COSTS DUE INSTANTER. COURT REPORTER WAIVED. ANY BOND NOT IN FORFEITURE IS TO BE EXONERATED.'
end
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in rspec we define variables using let

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants