added scraper functionality from scraper/attorney from oscn #16
Open
AspiringDev51 wants to merge 8 commits intomainfrom
Open
added scraper functionality from scraper/attorney from oscn #16AspiringDev51 wants to merge 8 commits intomainfrom
AspiringDev51 wants to merge 8 commits intomainfrom
Conversation
…craper for issue 30
…e/oscn_scraper into jw/oscn_issue-30-ok-bar
Simplecov Report
|
holdenmitchell
requested changes
Jul 21, 2022
Collaborator
holdenmitchell
left a comment
holdenmitchell
left a comment
There was a problem hiding this comment.
A couple of notes on this one:
- We want this to actually parse the data and return it as json (similar to you district attorney PR)
- We will want to add the
pagenumas a parameter for the class so that we can loop through the pagination by passing 1, 2, 3, 4, etc...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented solution for issue 30
How to test
Checklist