Skip to content

Pin resolvable release workflow actions#126

Merged
jmcte merged 2 commits into
mainfrom
codex/fix-release-action-pins
May 31, 2026
Merged

Pin resolvable release workflow actions#126
jmcte merged 2 commits into
mainfrom
codex/fix-release-action-pins

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 31, 2026

Summary

  • pin release cosign setup to the existing sigstore/cosign-installer@v4.1.2 tag
  • pin Scorecard to the existing ossf/scorecard-action@v2.4.3 tag
  • update workflow contract tests so unresolved major aliases do not regress back into CI

Verification

  • pnpm exec vitest run test/release-workflow.test.ts test/security-workflow.test.ts passed
  • pnpm lint passed
  • actionlint .github/workflows/release-image.yml .github/workflows/rg-release.yml .github/workflows/scorecard.yml passed

Issue Link

No issue is linked. This is a post-merge CI/release repair for the release workflows that failed after PR #123 merged and closed the governed issue batch.

@jmcte jmcte requested a review from pheidon May 31, 2026 09:38
@jmcte jmcte enabled auto-merge (squash) May 31, 2026 09:39
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d0588cb25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/scorecard.yml
Replace unresolved major action aliases with existing upstream tags for cosign-installer and Scorecard, and keep workflow contract tests aligned.

Verification: pnpm exec vitest run test/release-workflow.test.ts test/security-workflow.test.ts; pnpm lint; actionlint .github/workflows/release-image.yml .github/workflows/rg-release.yml .github/workflows/scorecard.yml
@jmcte jmcte force-pushed the codex/fix-release-action-pins branch from 9d0588c to 8fe2da1 Compare May 31, 2026 09:42
@jmcte
Copy link
Copy Markdown
Contributor Author

jmcte commented May 31, 2026

Addressed the automated Scorecard feedback in 8fe2da1 by moving write permissions off the workflow scope and onto the scorecard job, matching the scorecard-action v2 permission restrictions. Re-ran: pnpm exec vitest run test/release-workflow.test.ts test/security-workflow.test.ts; pnpm lint; actionlint .github/workflows/release-image.yml .github/workflows/rg-release.yml .github/workflows/scorecard.yml.

@jmcte
Copy link
Copy Markdown
Contributor Author

jmcte commented May 31, 2026

@pheidon PR #126 is ready for gate review. All PR checks are green or intentionally skipped, auto-merge is enabled, and the Scorecard permissions feedback was addressed in the current head 8fe2da1.

@athena-omt athena-omt added area:ai AI/model/agent behavior surface. area:infra Infrastructure, CI, release, governance, scripts, or repo setup. lane:hephaestus Hephaestus build/repo-ops lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review. labels May 31, 2026
Copy link
Copy Markdown
Contributor

@athena-omt athena-omt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confirming the existing Scorecard blocker rather than repeating the bot’s point: .github/workflows/scorecard.yml still grants id-token: write and security-events: write at workflow scope. The Scorecard v2 docs require “No workflow level write permissions” and say only the job running ossf/scorecard-action may use id-token: write, so this can still reject published results on push/schedule/manual runs. Please move the write permissions onto the scorecard job and keep the workflow-level permissions read-only.

@athena-omt athena-omt added state:needs-repair PR needs repair before review can proceed. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review. and removed status:needs-review PR is ready for Athena review. state:waiting-checks Waiting for CI/check status to settle. labels May 31, 2026
Copy link
Copy Markdown
Contributor

@pheidon pheidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the workflow pinning changes and aligned tests. The pinned cosign-installer v4.1.2 and scorecard-action v2.4.3 releases resolve upstream, Scorecard write permissions are now scoped to the scorecard job with workflow-level contents read, and CI/security checks are green. No blockers found.

@jmcte jmcte dismissed athena-omt’s stale review May 31, 2026 15:37

Scorecard blockers resolved

@jmcte jmcte merged commit 2822888 into main May 31, 2026
16 checks passed
@jmcte jmcte deleted the codex/fix-release-action-pins branch May 31, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai AI/model/agent behavior surface. area:infra Infrastructure, CI, release, governance, scripts, or repo setup. lane:hephaestus Hephaestus build/repo-ops lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. state:needs-repair PR needs repair before review can proceed. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants