Skip to content

Fix DAC1 API dimensions#31

Merged
jm-rivera merged 1 commit intomainfrom
fix-dac1-dataflow-issue
Apr 9, 2026
Merged

Fix DAC1 API dimensions#31
jm-rivera merged 1 commit intomainfrom
fix-dac1-dataflow-issue

Conversation

@jm-rivera
Copy link
Copy Markdown
Collaborator

This pull request updates the DAC1 query filter logic and documentation to match a new schema, which adds the SECTOR dimension at position 2. It also bumps the DAC1 dataflow version to 1.8 and updates related documentation and tests to reflect these changes.

DAC1 filter and schema alignment:

  • Updates the build_dac1_filter method in QueryBuilder to include the sector parameter as the second dimension, matching the new DSD schema. The filter pattern is now {donor}.{sector}.{measure}.{tying_status}.{flow_type}.{unit_measure}.{price_base}. [1] [2] [3]
  • Updates all relevant tests in test_query_builder.py to use the new filter string format with the SECTOR dimension in the correct position. [1] [2]
  • Updates documentation (advanced.md) to reflect the new dimension order and method signature for build_dac1_filter. [1] [2]

Version bumps:

  • Bumps the DAC1 dataflow version from 1.7 to 1.8 in dac1.py.
  • Updates the package version to 1.4.3 in pyproject.toml.
  • Adds a changelog entry for version 1.4.3, describing the schema change and version bump.

@jm-rivera jm-rivera merged commit eb6b75a into main Apr 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant