Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for reading Deflate64-compressed ZIP files, which are now used by the OECD for bulk data downloads. Since Python's standard
zipfilemodule does not natively support Deflate64, the package now patcheszipfileat runtime using theinflate64library to handle these files transparently. The update also includes new tests to ensure Deflate64 support works correctly, and addsinflate64as a dependency.Deflate64 ZIP Support:
src/oda_reader/download/_deflate64.py) that monkey-patches Python'szipfileto transparently support Deflate64 (compression type 9) for decompression using theinflate64library. Only reading is patched; writing Deflate64 ZIPs is not supported.src/oda_reader/download/download_tools.pyto ensure Deflate64 support is enabled for all downloads.Dependency Management:
inflate64(>=1.0.0) to the list of dependencies inpyproject.toml.Testing:
tests/download/unit/test_deflate64.pyto verify Deflate64 ZIP reading, including roundtrip tests and integration with the existing download tools for CSV, Parquet, and TXT files.Documentation:
CHANGELOG.mdto document Deflate64 support and the new dependency.