forked from openwisp/openwisp-controller
-
Notifications
You must be signed in to change notification settings - Fork 0
Update #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ONL
wants to merge
920
commits into
ONL:master
Choose a base branch
from
openwisp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a9ec58 to
b8169d9
Compare
- test_register_with_org_id: the test was passing without any change - test_register_with_org_param: trying to pass the org ID in the "organization" parameter caused an uncaught exception, the change in the code fixes the error
A regression prevented from changing the order of applied templates.
Controller views already return 404 response for disabled organizations. We only had to update the checksum cache. Closes #815
- Handled validation errors when cloning the template - When the user has access to multiple orgs, only allow to create templates in organization the user manages (is_admin=True)
- Prevent non superuser from creating shared templates - Prevent user to create templates in organization they don't manage
Removing VPN template from a device will not delete the related Cert object. Instead, it will mark the certificate as revoked. Closes #827
The app openwisp_users.accounts must come before allauth.account or some functionality of openwisp-users will fail.
DeviceConnection.update_config used to report the config as applied automatically, but this can potentially lead to inconsistencies. The config applied status is reported by the openwisp agent once the config has been applied successfully.
- Added more device, config and geo fields to export - Fixes #850
The get_temp_config_instance method of Device model completely ignored pre-existing attributes set on the config instance. This patches fixes it. This patch is necessary to allow the import functionality to import config data and context.
Ensured the following works: - Export devices using the export button on device changelist to CSV format - Import the exported devices in the previous step Added tests for main use cases. Some cases may be missing and we may have to fix them as we encounter them. Closes #793
Add WritableCommandInline to the DeviceAdmin only when the user has change permission for Command model.
Avoid manipulating private properties from Django.
Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
Fixes #1057 --------- Co-authored-by: Gagan Deep <pandafy.dev@gmail.com> Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Updates the requirements on [django-import-export](https://github.com/django-import-export/django-import-export) to permit the latest version. - [Release notes](https://github.com/django-import-export/django-import-export/releases) - [Changelog](https://github.com/django-import-export/django-import-export/blob/main/docs/changelog.rst) - [Commits](django-import-export/django-import-export@4.3.10...4.3.13) --- updated-dependencies: - dependency-name: django-import-export dependency-version: 4.3.13 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [django-import-export](https://github.com/django-import-export/django-import-export) to permit the latest version. - [Release notes](https://github.com/django-import-export/django-import-export/releases) - [Changelog](https://github.com/django-import-export/django-import-export/blob/main/docs/changelog.rst) - [Commits](django-import-export/django-import-export@4.3.13...4.3.14) --- updated-dependencies: - dependency-name: django-import-export dependency-version: 4.3.14 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Problem: Some tests in TestConfigApi assumed a fixed global Template count; which fail when other modules like openwisp-monitoring add new templates. Fix: Updated template-related assertions in test_api.py to compare counts relatively (eg: capture initial_count, assert +1). Fixes #442
Fixes #1110 [backport 1.2]
Co-authored-by: Alexandre Vincent <alexandre.vincent@stellar.tc>
- Was removed upstream - Will be removed, but we need it for CI builds in the short term
Django-x509 updates: - Migrated old jsonfield to Django JSONField - Added support for ECDSA algos
Implemented API to return indoor coordinates of devices for a given location. Closes #828 --------- Co-authored-by: Gagan Deep <pandafy.dev@gmail.com> [fix] Coderabbit comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.