Testing Babel#15
Draft
SriHV wants to merge 2 commits into
Draft
Conversation
rmccar
reviewed
Jan 30, 2025
| @@ -0,0 +1,3 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Do we need this empty line?
Contributor
|
We could do with a bit more of an explanation of the changes in this PR and a bit more detail on how to test. I understand what needs to be done but only because of previous knowledge. If we were to come back to this in the future to work out what changes were made and why it wouldn't be obvious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Raising this PR to test the PR that Andrew raised ONSdigital/design-system#3477
Created a new test page for this
How to review this PR
Follow the readme and run the command
poetry run flaskrun navigate tohttp://127.0.0.1:5000/test.See that with our previous code we get like