RAS-1901 Stale Pipenv lock on Secure messaging#465
Merged
Conversation
|
/deploy baileyw |
Collaborator
|
Deploying to dev cluster with following parameters:
|
|
/deploy bailew |
Collaborator
|
Deploying to dev cluster with following parameters:
|
warrenbaileyons
approved these changes
Apr 22, 2026
warrenbaileyons
left a comment
warrenbaileyons
left a comment
There was a problem hiding this comment.
Tested with the acceptance tests and by logging into both frontstage/rops and sending messages back and forth.
SteveScorfield
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
There was a subtle lock build change due to psycopg2-binary and a version of pipenv used by github, it has been fixed. I've had to completely regenerate the lock so there are other package updates, however only one, Marshmallow, caused issues. It now explicitly passes a data_key which was then causing our behave tests to fall over
How to test?
Deploy this branch and test both manually and with acceptance tests
Jira