Skip to content

Conversation

Copy link

Copilot AI commented Jan 6, 2026

Addresses review feedback requesting documentation consistency for the new SdkNoticeSubtype entity class.

Changes:

  • Updated entity package README to include SdkNoticeSubtype in the list of implemented entities
  • Added description: "Can hold information about a notice subtype from the SDK's notice-types.json file"
  • Updated entity count from three to four

The documentation now matches the pattern established for SdkField, SdkNode, and SdkCodelist.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rousso <91379+rousso@users.noreply.github.com>
Copilot AI changed the title [WIP] Add README reference for EFX rules translator Add SdkNoticeSubtype to entity package README Jan 6, 2026
Copilot AI requested a review from rousso January 6, 2026 17:07
@rousso rousso marked this pull request as ready for review January 6, 2026 18:35
@rousso rousso merged commit 2eb247e into TEDEFO-4805-efx-rules-translator Jan 6, 2026
@rousso rousso deleted the copilot/sub-pr-40-again branch January 6, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants