Skip to content

Add possibility for Sub-CA to be revoked, Removed auto-creation of empty crl for revokecertificate call with CA#3547

Merged
marcschier merged 7 commits intoOPCFoundation:masterfrom
KircMax:KircMax/RevokeSubCAPossible
Feb 17, 2026
Merged

Add possibility for Sub-CA to be revoked, Removed auto-creation of empty crl for revokecertificate call with CA#3547
marcschier merged 7 commits intoOPCFoundation:masterfrom
KircMax:KircMax/RevokeSubCAPossible

Conversation

@KircMax
Copy link
Contributor

@KircMax KircMax commented Feb 11, 2026

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If we do want to keep the comfort with the empty crl creation for cas we could add that if the CA is a root-ca but I am not sure that this is great behaviour to have that 'different handling'.

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 73.21429% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.81%. Comparing base (d25caff) to head (660b90f).
⚠️ Report is 117 commits behind head on master.

Files with missing lines Patch % Lines
...aries/Opc.Ua.Gds.Server.Common/CertificateGroup.cs 73.91% 6 Missing and 6 partials ⚠️
...ack/Opc.Ua.Core/Security/Certificates/X509Utils.cs 70.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3547       +/-   ##
===========================================
+ Coverage   51.86%   64.81%   +12.94%     
===========================================
  Files         370      458       +88     
  Lines       78618    96811    +18193     
  Branches    13650    16273     +2623     
===========================================
+ Hits        40779    62751    +21972     
+ Misses      33705    29042     -4663     
- Partials     4134     5018      +884     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier marcschier marked this pull request as draft February 11, 2026 18:28
add test for Test_Root_CA_throws_Exception + throw if applicable
use LoadCrlCreateEmptyIfNonExistantAsync
@KircMax KircMax marked this pull request as ready for review February 16, 2026 10:32
@KircMax KircMax requested a review from marcschier February 16, 2026 12:54
@marcschier marcschier merged commit 42addbb into OPCFoundation:master Feb 17, 2026
116 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to Revoke a Sub-CA using RevokeCertificate of CertificateGroup

3 participants

Comments