Skip to content

Add Regression Tests for EDITNNC/MULTREGT Combination#4974

Draft
bska wants to merge 1 commit intoOPM:masterfrom
bska:activate-editnnc-multregt-test
Draft

Add Regression Tests for EDITNNC/MULTREGT Combination#4974
bska wants to merge 1 commit intoOPM:masterfrom
bska:activate-editnnc-multregt-test

Conversation

@bska
Copy link
Member

@bska bska commented Nov 7, 2023

To guard against this combination failing in the future.

@bska
Copy link
Member Author

bska commented Nov 7, 2023

Uses the test case added in OPM/opm-tests#1065.

@bska bska force-pushed the activate-editnnc-multregt-test branch from 9d968a2 to ff1081c Compare November 7, 2023 19:05
@blattms
Copy link
Member

blattms commented Nov 8, 2023

jenkins build this please

Copy link
Member

@blattms blattms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks a lot. Highly appreciated.

@bska
Copy link
Member Author

bska commented Nov 8, 2023

jenkins build this please

Hm, the compareParallelSim test failed. I swear that worked locally on my machine. Please hold off while I look into this more closely.

@bska
Copy link
Member Author

bska commented Nov 8, 2023

Hm, the compareParallelSim test failed. I swear that worked locally on my machine. Please hold off while I look into this more closely.

The investigation is taking longer than expected. I'll reset the PR back to draft state to prevent inadvertent merging.

@bska bska marked this pull request as draft November 8, 2023 17:17
@bska bska force-pushed the activate-editnnc-multregt-test branch 10 times, most recently from f85007d to 19aed84 Compare November 15, 2023 15:22
@bska bska force-pushed the activate-editnnc-multregt-test branch 13 times, most recently from cd66122 to 8823ed1 Compare November 22, 2023 16:02
@bska bska force-pushed the activate-editnnc-multregt-test branch 8 times, most recently from 8b8846c to 236e530 Compare December 15, 2023 15:29
@bska bska force-pushed the activate-editnnc-multregt-test branch 3 times, most recently from 3859e77 to 910d1a4 Compare December 20, 2023 11:56
@bska bska force-pushed the activate-editnnc-multregt-test branch 5 times, most recently from 8bb4a79 to 8acfbf6 Compare January 5, 2024 12:38
@bska
Copy link
Member Author

bska commented Jan 5, 2024

jenkins build this please

@bska
Copy link
Member Author

bska commented Jan 5, 2024

jenkins build this please

@blattms : I still don't quite understand what's happening here, but if I limit the run to using the very small timestep of at most 0.1 day, then I can make the parallel test go through. Doing so feels a bit like a hack, however, so I'd prefer that we get analyse the problems further instead of merging this in its current state.

@bska bska force-pushed the activate-editnnc-multregt-test branch 9 times, most recently from eec33b1 to 723d654 Compare January 11, 2024 11:00
@bska
Copy link
Member Author

bska commented Jan 13, 2025

jenkins build this please

1 similar comment
@bska
Copy link
Member Author

bska commented May 9, 2025

jenkins build this please

To guard against this combination failing in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants