Conversation
Contributor
|
@vkatari10 The issues is that there is a hardcoded path of TrafficLayer in the SimpleTrafficLight/run_test.bat. Please revise it to be consistent with SimpleEchoClient. Also, please update the root/environment.yaml to have consistent environment name and add any missing packages there. Thanks |
yunlishao
reviewed
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Please do not change anything on this .yaml file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setup of
tests/Pythonon my local machine. Made slight modifications to some testing scripts, and added some comments to explain where port changes were made.Related Issues / Tasks
PR 1 for #122
Type of Change
Affected Modules / Components
Directory
tests/Python: https://github.com/ORNL-Real-Sim/FIXS/tree/main/tests/PythonTest Cases
Already implemented test scripts in the
tests/Pythonsub moduleEnvironment
Only fill in the tools used for testing this PR:
Checklist
Additional Notes (optional)
Still need to figure out why
SimpleTrafficLighttest fails to run independently without running the otherSimpleEchoClienttest script firstOther notes I took:
.cfgfile