-
Notifications
You must be signed in to change notification settings - Fork 12
fix for EKS deployment #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
5e6324b
901e8ef
f10a79b
4058d4f
2569ce4
51feae3
7ec5325
dc556a5
6af62ac
0e55505
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Use the command `make build` to build this image. | ||
| # Use conda-forge base image consistently across local/CI. | ||
| FROM condaforge/miniforge3:23.11.0-0 | ||
|
|
||
| WORKDIR /flowcept | ||
|
|
||
| COPY pyproject.toml Makefile README.md ./ | ||
| COPY src ./src | ||
| COPY resources ./resources | ||
| COPY notebooks ./notebooks | ||
| COPY tests ./tests | ||
| COPY examples ./examples | ||
|
|
||
| # Create env + install flowcept | ||
| RUN conda create -n flowcept python=3.11.10 -y && \ | ||
| conda run -n flowcept pip install -e .[lmdb,telemetry,dev,llm_agent,extras] | ||
|
|
||
| # Set env variables properly | ||
| ENV FLOWCEPT_SETTINGS_PATH=/flowcept/resources/sample_settings.yaml | ||
|
|
||
| # Expose MCP port | ||
| EXPOSE 8003 | ||
|
|
||
| # Start agent directly | ||
| CMD ["conda", "run", "--no-capture-output", "-n", "flowcept", "flowcept", "--start-agent"] |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @danielrosendo Read this warning :) Please don't manually change version.py
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did not change version is 'resources/sample_settings.yaml'. Made only this change:
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you change the file version.py? It looks changed in this PR.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, I did not touch version.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a Dockerfile. Do we need two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new file 'deployment/Dockerfile-aws' is a version that works for AWS EKS.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be made default in the existing Dockerfile
So the only conflict that would require further analysis and/or changes would be checking if we really need [all] -- we'd need to check the CI that uses the container and if, we really need [all], parametrizing it with
Docker build arguments (ARG)Something like:
Then you can pass specific deps in your build command like this:
Flowcept has several dependable services and can be started in multiple ways. I think having one Dockerfile per way makes it harder to maintain. Also, that Dockerfile can be reused in multiple other envs, including ORNL's OpenShift cluster not only EKS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!