t.list: Add output format options in t.list#7466
Open
saket0187 wants to merge 2 commits into
Open
Conversation
Member
|
If you're adding tests for more than what you added: a new PR to merge first (so then your PR changing the behaviour can catch if breaking something existing). If you're adding tests only for what you're adding (and it cannot impact existing code), then tests in this PR is welcome. @petrasovaa are pytest tests in temporal now behaving correctly? I remember seeing one of your PRs addressing something on the subject |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the feature requested in #7437
There is currently no test suite available for t.list. I wasn't sure if a new test file (e.g., using pytest) should be introduced in this PR, so I plan to address testing in a future PR instead. If there are any reference implementations or guidelines for using pytest within the temporal modules, please let me know!