feat: containerize setup with docker-compose and support HOST environment variable#1
Open
berezovskyi wants to merge 1 commit into
Open
feat: containerize setup with docker-compose and support HOST environment variable#1berezovskyi wants to merge 1 commit into
berezovskyi wants to merge 1 commit into
Conversation
Member
Author
|
To be combined with OSLC/bmm-server#1 |
There was a problem hiding this comment.
Pull request overview
Adds local containerized startup for the BMM OSLC server stack and improves default client/server configuration to work better in container environments.
Changes:
- Adds a multi-stage Dockerfile and a
docker-compose.ymlto runbmm-serverwith a Fuseki backend. - Adds
HOSTenvironment variable support for server listen binding. - Updates
oslc-browserto default its OSLC server URL to the current origin (/oslc).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Extends npm workspaces list to include additional packages. |
| oslc-browser/src/hooks/useOslcClient.ts | Sets a browser-origin-based default OSLC server URL. |
| mrm-server/src/env.ts | Adds support for HOST env var when selecting listen host. |
| Dockerfile | Introduces container build/runtime steps for the monorepo + BMM UI build. |
| docker-compose.yml | Defines local compose stack for Fuseki + bmm-server. |
| create-oslc-server.ts | Adds support for HOST env var when selecting listen host in generated servers. |
| .dockerignore | Reduces Docker build context by excluding common large/unneeded paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
636
to
640
| const saved = loadSavedConnection(); | ||
| const defaultURL = typeof window !== 'undefined' ? `${window.location.origin}/oslc` : ''; | ||
| return { | ||
| serverURL: saved.serverURL ?? '', | ||
| serverURL: saved.serverURL ?? defaultURL, | ||
| username: saved.username ?? '', |
Comment on lines
+7
to
+25
| COPY oslc4js/package*.json ./ | ||
| COPY oslc4js/storage-service/package*.json ./storage-service/ | ||
| COPY oslc4js/jena-storage-service/package*.json ./jena-storage-service/ | ||
| COPY oslc4js/ldp-service/package*.json ./ldp-service/ | ||
| COPY oslc4js/oslc-service/package*.json ./oslc-service/ | ||
| COPY oslc4js/oslc-client/package*.json ./oslc-client/ | ||
| COPY oslc4js/oslc-browser/package*.json ./oslc-browser/ | ||
| COPY bmm-server/package*.json ./bmm-server/ | ||
| COPY bmm-server/ui/package*.json ./bmm-server/ui/ | ||
|
|
||
| # Install workspaces dependencies | ||
| RUN npm install | ||
|
|
||
| # Copy the entire monorepo source code | ||
| COPY oslc4js/ . | ||
|
|
||
| # Overwrite bmm-server with the standalone bmm-server source code | ||
| COPY bmm-server/ ./bmm-server/ | ||
|
|
Comment on lines
+51
to
+54
| WORKDIR /usr/src/app/bmm-server | ||
| RUN chmod +x start.sh testing/populate-eurent.sh | ||
|
|
||
| CMD ["./start.sh"] |
Comment on lines
+15
to
+17
| build: | ||
| context: .. | ||
| dockerfile: oslc4js/Dockerfile |
Comment on lines
+14
to
+16
| "bmm-server", | ||
| "oslc-client", | ||
| "oslc-browser" |
Member
Author
There was a problem hiding this comment.
Hmm, is this a copilot problem resolving a submodule?
berezovskyi
force-pushed
the
feature/docker-compose-automation
branch
from
dff1a80 to
6ca386c
Compare
berezovskyi
force-pushed
the
feature/docker-compose-automation
branch
from
6ca386c to
2ad81ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with OSLC/bmm-server#1 this PR:
docker compose uphttp://localhost:3005/oslcin the Server URL field for smoother first-run experience.