add typescript declarations#30
add typescript declarations#30paolotiu wants to merge 1 commit intoOSSPhilippines:masterfrom paolotiu:add-typescript-types
Conversation
jofftiquez
left a comment
jofftiquez
left a comment
There was a problem hiding this comment.
Hi, thank you for this PR. Really great help. Just a few comments and this is good to go.
Along with the comments above, please include the following as well:
- Use 2 spaces for tabs.
- Run the linter before pushing.
| @@ -0,0 +1 @@ | |||
| export * from "./payment-intents"; | |||
There was a problem hiding this comment.
Please use single quote ' instead of double quotes ". Thanks.
| @@ -0,0 +1 @@ | |||
| export * from "./payment-methods"; | |||
There was a problem hiding this comment.
Please use single quote ' instead of double quotes ". Thanks.
| @@ -0,0 +1 @@ | |||
| export * from "./payments"; | |||
There was a problem hiding this comment.
Please use single quote ' instead of double quotes ". Thanks.
| @@ -0,0 +1 @@ | |||
| export * from "./sources"; | |||
There was a problem hiding this comment.
Please use single quote ' instead of double quotes ". Thanks.
| @@ -0,0 +1 @@ | |||
| export * from "./tokens"; | |||
There was a problem hiding this comment.
Please use single quote ' instead of double quotes ". Thanks.
| @@ -0,0 +1 @@ | |||
| export * from "./webhooks"; | |||
There was a problem hiding this comment.
Please use single quote ' instead of double quotes ". Thanks.
|
Hello @paolotiu thanks for this, I'm not an expert in TS so please let me know if there are invalid comments from what I added above. Thanks again. |
Hello @jofftiquez, the declaration files are auto-generated. As far as I know, there isn't an option to change the code style. I could change it manually, but it would be reset on the next build. Thank you! |
|
Hi @jofftiquez, no updates on this one if ever? Thanks. |
Hello, there's no updates in the PR comments yet. But if you can check them so we can merge them immediately. |
3 participants
No description provided.