Avoid wrong use of secret key with multiple paymongo account on the same application runtime#54
Open
shlowmo wants to merge 2 commits intoOSSPhilippines:masterfrom
Open
Avoid wrong use of secret key with multiple paymongo account on the same application runtime#54shlowmo wants to merge 2 commits intoOSSPhilippines:masterfrom
shlowmo wants to merge 2 commits intoOSSPhilippines:masterfrom
Conversation
…2 paymongo account
fix-multi-account-secret-key-error
jofftiquez
requested changes
Mar 12, 2024
| if (Paymongo.instance instanceof Paymongo) return Paymongo.instance; | ||
| if (!secret) throw new Error('API key is required!'); | ||
|
|
||
| if (Paymongo.instance instanceof Paymongo) { |
Member
There was a problem hiding this comment.
This can be done in a single if for cleaner code.
if (Paymongo.instance instanceof Paymongo && Paymongo.instance.secret === secret)Kindly update, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double check existing instance API key in constructor
Resolves #50