fix: give update-flake PR commits a real message#5
Merged
Conversation
The Create PR step set the PR title and body but not commit-message, so
peter-evans/create-pull-request fell back to its placeholder ("[create-pull-request]
automated change") for the actual commit. The PR looked fine while the commit log
that lands on the base branch was useless.
Pass commit-message explicitly: the pr-title as the summary line followed by Nix's
per-input changelog (the same body shown in the PR), restoring the informative
"<title>\n\n<changelog>" commit the previous update-flake-lock produced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
commit-messageto create-pull-request so the commit that lands on the base branch is<pr-title>+ Nix's per-input changelog, instead of the placeholder[create-pull-request] automated change. Fixes a regression in v1.0.1.