Skip to content

Dev#267

Merged
OrenZhang merged 180 commits intomainfrom
dev
Mar 2, 2026
Merged

Dev#267
OrenZhang merged 180 commits intomainfrom
dev

Conversation

@OrenZhang
Copy link
Copy Markdown
Collaborator

No description provided.

ShirasawaSama and others added 30 commits February 23, 2026 21:48
feat: sort action buttons by valve priority

Action buttons under assistant messages were rendered in
non-deterministic order due to set() deduplication. They now
respect the priority field from function Valves, sorted ascending
(lower value = appears first, default 0), matching the existing
filter priority mechanism.
…iation (#21841)

fix: resolve valve priority for actions and filters via class instantiation

The priority sorting for action buttons and filter execution order
read valve data directly from the database JSON column using
Functions.get_function_valves_by_id(). This returns only explicitly
saved values — when a developer defines priority as a class default
in their Valves definition (e.g. priority: int = 5) without ever
opening the Valves UI to persist it, the database column remains
empty. Every function then resolves to priority 0, and the preceding
set() deduplication produces non-deterministic iteration order that
the stable sort preserves — resulting in random button placement on
every page load.

The fix instantiates the Valves class with database values as keyword
overrides: Valves(**(db_valves or {})). This merges any persisted
overrides onto the code-defined defaults, matching the pattern already
established in the action execution handler, filter processing
pipeline, and tool module initialization. A secondary sort key (the
function ID) ensures fully deterministic ordering even when multiple
functions share the same priority value.

Affected locations:
- get_action_priority in utils/models.py (action button ordering)
- get_priority in utils/filter.py (filter execution ordering)
Co-Authored-By: Peter L Jones <1549463+pljones@users.noreply.github.com>
Co-Authored-By: Johannes Fahrenkrug <16358+jfahrenkrug@users.noreply.github.com>
tjbck and others added 28 commits March 1, 2026 13:37
…SA-vvxm-vxmr-624h) (#22108)

- Use os.path.basename() for filename sanitization instead of fragile blocklist

- Replace ERROR_MESSAGES.DEFAULT(e) with generic error message in both except blocks to prevent CWE-209 information disclosure

- Server-side logging via log.exception(e) is preserved for debugging
…2098)

Same optimization as the merged ResponseMessage PR: replace JSON.parse(JSON.stringify()) with structuredClone and add an O(1) fast-path check on content before falling back to full JSON.stringify comparison.
* fix: enforce ownership check on user-memory collection queries

fix: enforce ownership check on user-memory collection queries

Prevent authenticated users from querying other users' memory
collections via the /query/doc and /query/collection endpoints.
A new _validate_collection_access helper rejects requests for
user-memory-{UUID} collections where the UUID does not match
the requesting user. Admins bypass the check.

* Update retrieval.py

* Update retrieval.py
* fix: fix memory leaking in Chat.svelte

* chore: remove useless chatIdUnsubscriber var

* fix: fix async tick
perf: use rAF to debounce getContents() during streaming
The system prompt and other chat controls overrides were lost after
saving because `params` wasn't included in the `createNewChat` call.
fix: pass params when saving a temporary chat
# Conflicts:
#	.github/workflows/docker-build.yaml
#	backend/open_webui/config.py
#	backend/open_webui/main.py
#	backend/open_webui/utils/response.py
#	package-lock.json
#	package.json
#	src/lib/components/admin/Settings.svelte
#	src/lib/components/layout/Sidebar/ChatItem.svelte
#	src/lib/i18n/locales/ar-BH/translation.json
#	src/lib/i18n/locales/ar/translation.json
#	src/lib/i18n/locales/bg-BG/translation.json
#	src/lib/i18n/locales/bn-BD/translation.json
#	src/lib/i18n/locales/bo-TB/translation.json
#	src/lib/i18n/locales/bs-BA/translation.json
#	src/lib/i18n/locales/ca-ES/translation.json
#	src/lib/i18n/locales/ceb-PH/translation.json
#	src/lib/i18n/locales/cs-CZ/translation.json
#	src/lib/i18n/locales/da-DK/translation.json
#	src/lib/i18n/locales/de-DE/translation.json
#	src/lib/i18n/locales/dg-DG/translation.json
#	src/lib/i18n/locales/el-GR/translation.json
#	src/lib/i18n/locales/en-GB/translation.json
#	src/lib/i18n/locales/en-US/translation.json
#	src/lib/i18n/locales/es-ES/translation.json
#	src/lib/i18n/locales/et-EE/translation.json
#	src/lib/i18n/locales/eu-ES/translation.json
#	src/lib/i18n/locales/fa-IR/translation.json
#	src/lib/i18n/locales/fi-FI/translation.json
#	src/lib/i18n/locales/fr-CA/translation.json
#	src/lib/i18n/locales/fr-FR/translation.json
#	src/lib/i18n/locales/gl-ES/translation.json
#	src/lib/i18n/locales/he-IL/translation.json
#	src/lib/i18n/locales/hi-IN/translation.json
#	src/lib/i18n/locales/hr-HR/translation.json
#	src/lib/i18n/locales/hu-HU/translation.json
#	src/lib/i18n/locales/id-ID/translation.json
#	src/lib/i18n/locales/ie-GA/translation.json
#	src/lib/i18n/locales/it-IT/translation.json
#	src/lib/i18n/locales/ja-JP/translation.json
#	src/lib/i18n/locales/ka-GE/translation.json
#	src/lib/i18n/locales/kab-DZ/translation.json
#	src/lib/i18n/locales/ko-KR/translation.json
#	src/lib/i18n/locales/lt-LT/translation.json
#	src/lib/i18n/locales/lv-LV/translation.json
#	src/lib/i18n/locales/ms-MY/translation.json
#	src/lib/i18n/locales/nb-NO/translation.json
#	src/lib/i18n/locales/nl-NL/translation.json
#	src/lib/i18n/locales/pa-IN/translation.json
#	src/lib/i18n/locales/pl-PL/translation.json
#	src/lib/i18n/locales/pt-BR/translation.json
#	src/lib/i18n/locales/pt-PT/translation.json
#	src/lib/i18n/locales/ro-RO/translation.json
#	src/lib/i18n/locales/ru-RU/translation.json
#	src/lib/i18n/locales/sk-SK/translation.json
#	src/lib/i18n/locales/sr-RS/translation.json
#	src/lib/i18n/locales/sv-SE/translation.json
#	src/lib/i18n/locales/th-TH/translation.json
#	src/lib/i18n/locales/tk-TM/translation.json
#	src/lib/i18n/locales/tr-TR/translation.json
#	src/lib/i18n/locales/ug-CN/translation.json
#	src/lib/i18n/locales/uk-UA/translation.json
#	src/lib/i18n/locales/ur-PK/translation.json
#	src/lib/i18n/locales/uz-Cyrl-UZ/translation.json
#	src/lib/i18n/locales/uz-Latn-Uz/translation.json
#	src/lib/i18n/locales/vi-VN/translation.json
#	src/lib/i18n/locales/zh-CN/translation.json
#	src/lib/i18n/locales/zh-TW/translation.json
await session.close()
log.exception("Terminal proxy error: %s", error)
return JSONResponse(
{"error": f"Terminal proxy error: {error}"}, status_code=502

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
@OrenZhang OrenZhang merged commit 70b9fe2 into main Mar 2, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.