fix(e2e): complete Cypress migration and stabilize make e2e for #523#774
Open
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Open
fix(e2e): complete Cypress migration and stabilize make e2e for #523#774PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Conversation
Contributor
Author
|
Hi @northdpole picked this up based on your earlier guidance to finish the Cypress migration for e2e. PR #774 incorporates the prior review iterations from related e2e threads (#729, #732) and is scoped to resolve #523:
Validation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523
Summary
This PR completes the E2E migration path to Cypress and restores a working smoke test flow.
What changed
test:e2efromjesttocypress runinpackage.jsoncypress:opencypress:runcypress.config.jscypress/e2e/smoke.cy.jscypress.jsonapplication/frontend/src/test/basic-e2e.test.ts(commented Jest/Puppeteer test)make e2einMakefile:127.0.0.1:5000env -u ELECTRON_RUN_AS_NODE yarn test:e2efor stable Cypress executionplaywright installstep frominstall-python(Makefile), consistent with Cypress migrationValidation
make e2e3 passing, 0 failingScope notes