fix(wayfinder): improve filter reliability and UI clarity (fixes #426)#781
Open
PRAteek-singHWY wants to merge 4 commits intoOWASP:mainfrom
Open
fix(wayfinder): improve filter reliability and UI clarity (fixes #426)#781PRAteek-singHWY wants to merge 4 commits intoOWASP:mainfrom
PRAteek-singHWY wants to merge 4 commits intoOWASP:mainfrom
Conversation
Contributor
Author
|
@northdpole quick update on #426:
Data note:
PRs:
Looking forward to iterating based on any feedback or change requests. |
c1f02ad to
1278173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer Notes
Why this follow-up PR
#780 introduced the core Product Security Wayfinder API + UI. This follow-up tightens correctness and usability in places that showed up during real local testing:
What Changed in this PR
sdlc=x&sdlc=y, etc.), which Flask correctly reads viarequest.args.getlist(...).CWE-22 -> CWE,CAPEC-111 -> CAPEC, and generic placeholders removal).Clear filterscontrast.Data Source (OpenCRE Data Only)
Relevant Files
application/database/db.pyapplication/utils/wayfinder_metadata.pyapplication/tests/wayfinder_metadata_test.pyapplication/frontend/src/pages/Wayfinder/Wayfinder.tsxapplication/frontend/src/pages/Wayfinder/wayfinder.scssHow I Tested Locally
source venv/bin/activateexport DEV_DATABASE_URL="sqlite:////Users/prateeksingh/OpenCRE/standards_cache.sqlite"NO_LOAD_GRAPH_DB=1 make dev-flaskcd application/frontend && yarn starthttp://localhost:9001/wayfindercurl -s http://127.0.0.1:5000/rest/v1/wayfinder | jq '.stats'curl -s "http://127.0.0.1:5000/rest/v1/wayfinder?sdlc=Operations" | jq '.stats'Automated Validation
yarn buildpasses.venv/bin/python -m unittest application.tests.wayfinder_metadata_testpasses.venv/bin/python -m unittest application.tests.web_main_test.TestMain.test_wayfinder_payload_shape application.tests.web_main_test.TestMain.test_wayfinder_filterspasses.Screenshots