fix(scripts): return None from get_docx_document on missing template

.github/workflows/run-tests-generate-output.yaml

@@ -36,7 +36,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           ref: ${{ github.event.pull_request.head.sha }}
-          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          fetch-depth: 0
           persist-credentials: false
       # Set the pip environment up
       - name: Get Python
@@ -170,10 +170,6 @@ jobs:
       issues: write
     needs: uploadoutputfiles
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
       - name: Download translation check report
         uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
         with:

copi.owasp.org/test/copi_web/controllers/health_controller_test.exs

@@ -0,0 +1,9 @@
+defmodule CopiWeb.HealthControllerTest do
+  use CopiWeb.ConnCase
+
+  test "GET /health returns 200 when database is available", %{conn: conn} do
+    conn = get(conn, "/health")
+    assert conn.status == 200
+    assert conn.resp_body == "healthy\n"
+  end
+end

scripts/check_translations.py

@@ -214,11 +214,31 @@ def main() -> None:
         sys.exit(1)
 
     # Run checker
-    checker = TranslationChecker(source_dir, 
-        excluded_tags=["T02330", "T02530", 
-            "T03130", "T03150", "T03170", "T03190", "T03240", "T03260",
-            "T03350", "T03420", "T03470", "T03490", "T03540", "T03580",
-            "T03710", "T03730", "T03750", "T03770", "T03772", "T03774"])
+    checker = TranslationChecker(
+        source_dir,
+        excluded_tags=[
+            "T02330",
+            "T02530",
+            "T03130",
+            "T03150",
+            "T03170",
+            "T03190",
+            "T03240",
+            "T03260",
+            "T03350",
+            "T03420",
+            "T03470",
+            "T03490",
+            "T03540",
+            "T03580",
+            "T03710",
+            "T03730",
+            "T03750",
+            "T03770",
+            "T03772",
+            "T03774",
+        ],
+    )
     results = checker.check_translations()
 
     # Generate report

scripts/convert.py

@@ -11,7 +11,7 @@
 import zipfile
 import xml.etree.ElementTree as ElTree
 from defusedxml import ElementTree as DefusedElTree
-from typing import Any, Dict, List, Tuple, cast
+from typing import Any, Dict, List, Optional, Tuple, cast
 from operator import itemgetter
 from itertools import groupby
 from pathlib import Path
@@ -291,9 +291,12 @@ def create_edition_from_template(
         if file_extension == ".docx":
             # Get the input (template) document
             doc = get_docx_document(template_doc)
-            if doc:
+            if doc is not None:
                 doc = replace_docx_inline_text(doc, language_dict)
                 doc.save(output_file)
+            else:
+                logging.error("Cannot create output file: template document not found at %s", template_doc)
+                return
         else:
             save_odt_file(template_doc, language_dict, output_file)
 
@@ -550,16 +553,15 @@ def get_document_paragraphs(doc: Any) -> List[Any]:
     return paragraphs
 
 
-def get_docx_document(docx_file: str) -> Any:
-    """Open the file and return the docx document."""
+def get_docx_document(docx_file: str) -> Optional[Any]:
+    """Open the file and return the docx document, or None if the file is not found."""
     import docx  # type: ignore[import-untyped]
 
     if os.path.isfile(docx_file):
         return docx.Document(docx_file)
     else:
         logging.error("Could not find file at: %s", str(docx_file))
-        # Create a blank document if it fails
-        return docx.Document()
+        return None
 
 
 def get_files_from_of_type(path: str, ext: str) -> List[str]: