perf(remediation): replace linear packages.find() with Map lookup for O(1) access#653
Merged
Merged
Conversation
… O(1) access Refs #645
sonukapoor
force-pushed
the
perf/issue-645-map-based-lookup
branch
from
99ba6f9 to
263f6ad
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace O(n) linear
packages.find()scans with O(1) Map lookups in the transitive remediation and parent-upgrade functions.Before:
packages.find(p => p.name === name)on every call — O(n) per lookupAfter: Pre-built
Map<string, PackageRef>— O(1) per lookupRefs #645