perf(npm-lock-graph): pre-freeze node objects at construction time; remove redundant uniquePathArrays#654
Merged
Conversation
…ion time; remove redundant uniquePathArrays Refs #645
sonukapoor
force-pushed
the
perf/issue-645-prefreeze-nodes
branch
from
efb5a87 to
b95f8b2
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements to
createGraphin the npm lock graph parser:Fix 3: Pre-compute frozen node objects and arrays at construction time.
getNode(),nodeIdsFor(),parentsFor(),childrenFor()now return pre-frozen values from Maps instead of callingObject.freeze({ ...node })on every access.Fix 4: Remove redundant
uniquePathArrays()frompathsFor()— theSet<string>source already guarantees uniqueness.Refs #645