Fixes OWASP/mastg#2585 [MASWE-0021] Weak Hashing#2
Open
sydseter wants to merge 18 commits intoOWASP:mainfrom
Open
Fixes OWASP/mastg#2585 [MASWE-0021] Weak Hashing#2sydseter wants to merge 18 commits intoOWASP:mainfrom
sydseter wants to merge 18 commits intoOWASP:mainfrom
Conversation
sydseter
changed the title
Diolor
suggested changes
Oct 29, 2025
Co-authored-by: Dionysis Lorentzos <ddl449@gmail.com>
Co-authored-by: Dionysis Lorentzos <ddl449@gmail.com>
Updated language for clarity and consistency regarding hashing algorithms and their vulnerabilities.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR completes the documentation for MASWE-0021 (Improper Hashing), transitioning it from placeholder status to a full weakness description. The PR adds comprehensive content covering cryptographic hashing vulnerabilities, their impact, modes of introduction, and mitigation strategies.
Key Changes:
- Added complete weakness documentation with Overview, Impact, Modes of Introduction, and Mitigations sections
- Updated references to include additional NIST and CWE resources
- Changed status from "placeholder" to "new"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cpholguera
requested changes
Nov 15, 2025
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Collaborator
|
@Diolor could you please take another look? We added a couple of changes. |
Diolor
reviewed
Nov 20, 2025
Removed duplicate entries in the Modes of Introduction and Mitigations sections for clarity.
Removed mentions of raw hash constructions and HMAC from the modes of introduction and mitigations sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2585
Description
See issue for details
[x] I have read the contributing guidelines.
Guidelines for Pull Requests (you can delete this section after reading):