Open
Conversation
cpholguera
requested changes
Sep 12, 2025
Collaborator
There was a problem hiding this comment.
Mitigations section is missing
See example here:
https://github.com/OWASP/maswe/blob/main/weaknesses/MASVS-CRYPTO/MASWE-0009.md?plain=1
Guidelines: https://docs.google.com/document/d/1EMsVdfrDBAu0gmjWAUEs60q-fWaOmDB5oecY9d9pOlg/edit?usp=sharing
Comment on lines
+39
to
+44
| To summarize: | ||
|
|
||
| - **Device attestation** confirms the environment is trustworthy. | ||
| - **App attestation** confirms the app instance is trustworthy. | ||
|
|
||
| If the app doesn't use attestation APIs or services the backend cannot ensure requests originate from a genuine app binary and from a trusted platform. |
Collaborator
There was a problem hiding this comment.
I'd not "summarize" here, prefer to make it more explicit above, e.g., using the bullet points.
Diolor
reviewed
Nov 1, 2025
cpholguera
reviewed
Nov 2, 2025
| @@ -1,2 +1,2 @@ | |||
| --- | |||
| title: Device Attestation Not Implemented | |||
Collaborator
There was a problem hiding this comment.
See https://github.com/OWASP/mastg/issues/3503#issuecomment-3477881489
Suggested change
| title: Missing or Incorrect Device Attestation |
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #38