Skip to content

Migrate Example Scripts to Python3#90

Merged
randomstr1ng merged 37 commits into
OWASP:masterfrom
randomstr1ng:migrate-example-scripts
Jul 1, 2026
Merged

Migrate Example Scripts to Python3#90
randomstr1ng merged 37 commits into
OWASP:masterfrom
randomstr1ng:migrate-example-scripts

Conversation

@randomstr1ng

@randomstr1ng randomstr1ng commented May 19, 2026

Copy link
Copy Markdown
Collaborator

This PR ensures full python3 compatibility for all example scripts.

Checklist diag_*

  • diag_capturer.py
  • diag_dos_exploit.py (does not error out; full function test not possible to due lack of vulnerable system)
  • diag_interceptor.py
  • diag_login_brute_force.py
  • diag_login_screen_info.py
  • diag_render_login_screen.py
  • diag_rogue_server.py

Checklist igs_*

  • igs_http_imgconv.py
  • igs_http_xmlchart.py
  • igs_http_zipper.py
  • igs_rfc_zipper.py

Checklist ms_*

  • ms_change_param.py
  • ms_dos_exploit.py (does not error out; full function test not possible to due lack of vulnerable system)
  • ms_dump_info.py
  • ms_dump_param.py
  • ms_impersonator.py
  • ms_listener.py
  • ms_messager.py
  • ms_monitor.py
  • ms_observer.py

Checklist router_*

  • router_admin.py
  • router_fingerprint.py
  • router_niping.py
  • router_password_check.py
  • router_portfw.py
  • router_scanner.py

Checklist "misc"

  • dlmanager_decrypt.py
  • dlmanager_infector.py
  • enqueue_dos_exploit.py (does not error out; full function test not possible to due lack of vulnerable system)
  • enqueue_monitor.py
  • gw_monitor.py
  • hdb_auth.py
  • hdb_discovery.py

@randomstr1ng
randomstr1ng marked this pull request as ready for review May 19, 2026 15:48
@randomstr1ng

Copy link
Copy Markdown
Collaborator Author

@martingalloar & @codeHorse87 - I did some updates to the diag_* examples and fixed some bugs along the way. let me know if anything needs to be adjusted.

@randomstr1ng randomstr1ng changed the title Migrate Diag Example Scripts to Python3 Migrate Example Scripts to Python3 Jun 1, 2026
@martingalloar
martingalloar marked this pull request as draft June 1, 2026 14:30
@randomstr1ng
randomstr1ng marked this pull request as ready for review June 7, 2026 10:32
@randomstr1ng

Copy link
Copy Markdown
Collaborator Author

@martingalloar - done with checking all example scripts (as far as I was able to). Identified some issues in the core modules which are fixed now.

please review and merge if you do not see any other issues.

thank you!

@randomstr1ng

Copy link
Copy Markdown
Collaborator Author

hi @martingalloar ,

just want to check if we can merge the PR?

Thank you!

@martingalloar

Copy link
Copy Markdown
Collaborator

Sorry for the delay, I do have some additional/related changes in progress but we might want to split and break those down into a separate PR. let me do a final review on examples and we should be ready to merge!

@randomstr1ng

Copy link
Copy Markdown
Collaborator Author

no worries - I also do have some additional changes and bugfixes but those are related to the HoneSAP PR. I will also submit them in a separate PR.

thank you!

@martingalloar

Copy link
Copy Markdown
Collaborator

Pushed d826e13 with fixes for the Python 3 migration edge cases: strict SAPNI decoding restored, bodyless IGS HTTP handled, SAP Router route/framing covered, and example error handling hardened. Focused regressions pass; broader unit run still has the existing SAPRFCTHStruct round-trip failures.

@martingalloar

Copy link
Copy Markdown
Collaborator

@randomstr1ng whenever possible please check the changes I just pushed! Unless you see something off I believe it's in a very good shape now, and it's actually a great addition!

@randomstr1ng

Copy link
Copy Markdown
Collaborator Author

@martingalloar thank you for your enhancements and review. Looks all good on my end. So I think we can merge this and proceed with the next steps.

@randomstr1ng
randomstr1ng merged commit b931106 into OWASP:master Jul 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants