Migrate Example Scripts to Python3#90
Conversation
…are provided in a credentialfile
|
@martingalloar & @codeHorse87 - I did some updates to the |
…n shutdown for ms_impersonator
…ap-dev into migrate-example-scripts
…move python2 dependency
|
@martingalloar - done with checking all example scripts (as far as I was able to). Identified some issues in the core modules which are fixed now. please review and merge if you do not see any other issues. thank you! |
|
hi @martingalloar , just want to check if we can merge the PR? Thank you! |
|
Sorry for the delay, I do have some additional/related changes in progress but we might want to split and break those down into a separate PR. let me do a final review on examples and we should be ready to merge! |
|
no worries - I also do have some additional changes and bugfixes but those are related to the HoneSAP PR. I will also submit them in a separate PR. thank you! |
|
Pushed d826e13 with fixes for the Python 3 migration edge cases: strict SAPNI decoding restored, bodyless IGS HTTP handled, SAP Router route/framing covered, and example error handling hardened. Focused regressions pass; broader unit run still has the existing SAPRFCTHStruct round-trip failures. |
|
@randomstr1ng whenever possible please check the changes I just pushed! Unless you see something off I believe it's in a very good shape now, and it's actually a great addition! |
|
@martingalloar thank you for your enhancements and review. Looks all good on my end. So I think we can merge this and proceed with the next steps. |
This PR ensures full python3 compatibility for all example scripts.
Checklist
diag_*(does not error out; full function test not possible to due lack of vulnerable system)Checklist
igs_*Checklist
ms_*(does not error out; full function test not possible to due lack of vulnerable system)Checklist
router_*Checklist "misc"
(does not error out; full function test not possible to due lack of vulnerable system)