Fix str/byte type errors#92
Merged
Merged
Conversation
Collaborator
|
Thanks @DominikHolzapfel! This looks good, I only added a test case to validate any potential regression, please report if there's any other issue running your tool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using https://github.com/SecuritySilverbacks/sncscan with this pysap library, I ran into an issue where TypeErrors were raised to due a mismatch between String and Bytes.
Scapy operates on byte buffers, and pysap sometimes returns a string.
I encountered it in StrEncodedPaddedField and fixed it similar to the sibling classes StrFixedLenPaddedField and StrNullFixedLenPaddedField.
In addition, there are two more spots in the code where a byte should be returned.