Skip to content

*: add duties cache #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KaloyanTanev wants to merge 12 commits into
base: main
Choose a base branch
from
+1,273 −562
Draft

*: add duties cache #4227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd7b00b
Add duties cache
KaloyanTanev Jan 16, 2026
b5f3d01
Fix beaconmock
KaloyanTanev Jan 16, 2026
a2d6fe7
Invalidate duties cache on reorg event
KaloyanTanev Jan 19, 2026
609c797
Add validator indices to calls
KaloyanTanev Jan 19, 2026
37f11f5
Add cache function to synth proposer
KaloyanTanev Jan 20, 2026
45c2261
Remove Teku testing
KaloyanTanev Jan 20, 2026
75306e9
Add duties cache to vmock
KaloyanTanev Jan 20, 2026
042f352
Fix appending to same slice
KaloyanTanev Jan 23, 2026
75910d9
Fix tests
KaloyanTanev Jan 23, 2026
ad8f4fe
Fix TestResolveAttDuties test
KaloyanTanev Jan 25, 2026
5c3456f
Fix TestSchedulerDuties test
KaloyanTanev Jan 25, 2026
eff332f
Fix multi tests for cache
KaloyanTanev Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,16 +480,22 @@ func wireCoreWorkflow(ctx context.Context, life *lifecycle.Manager, conf Config,
valCache := eth2wrap.NewValidatorCache(eth2Cl, eth2Pubkeys)
eth2Cl.SetValidatorCache(valCache.GetByHead)

firstValCacheRefresh := true
firstCacheRefresh := true
refreshedBySlot := true

// Setup duties cache, refreshing it every epoch.
dutiesCache := eth2wrap.NewDutiesCache(eth2Cl, []eth2p0.ValidatorIndex{})
eth2Cl.SetDutiesCache(dutiesCache.ProposerDutiesCache, dutiesCache.AttesterDutiesCache, dutiesCache.SyncCommDutiesCache)

sseListener.SubscribeChainReorgEvent(dutiesCache.InvalidateCache)

Comment on lines +486 to +491
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DutiesCache is created and hooked into the client, but it is never trimmed on epoch boundaries (only validator cache is trimmed). Since DutiesCache retains maps keyed by epoch, this will grow unbounded over time unless Trim is called periodically (e.g., alongside valCache.Trim() on refresh).

Copilot uses AI. Check for mistakes.
var fvcrLock sync.RWMutex

shouldUpdateCache := func(slot core.Slot, lock *sync.RWMutex) bool {
lock.RLock()
defer lock.RUnlock()

if !slot.FirstInEpoch() && !firstValCacheRefresh && refreshedBySlot {
if !slot.FirstInEpoch() && !firstCacheRefresh && refreshedBySlot {
return false
}

Expand All @@ -504,7 +510,7 @@ func wireCoreWorkflow(ctx context.Context, life *lifecycle.Manager, conf Config,
fvcrLock.Lock()
defer fvcrLock.Unlock()

ctx = log.WithCtx(ctx, z.Bool("first_refresh", firstValCacheRefresh))
ctx = log.WithCtx(ctx, z.Bool("first_refresh", firstCacheRefresh))

log.Info(ctx, "Refreshing validator cache")

Expand All @@ -518,14 +524,21 @@ func wireCoreWorkflow(ctx context.Context, life *lifecycle.Manager, conf Config,

valCache.Trim()

_, _, refresh, err := valCache.GetBySlot(ctx, slotToFetch)
activeValidators, _, refresh, err := valCache.GetBySlot(ctx, slotToFetch)
if err != nil {
log.Error(ctx, "Failed to refresh validator cache", err)
return err
}

vIdxs := []eth2p0.ValidatorIndex{}
for idx := range activeValidators {
vIdxs = append(vIdxs, idx)
}

dutiesCache.UpdateCacheIndices(ctx, vIdxs)

refreshedBySlot = refresh
firstValCacheRefresh = false
firstCacheRefresh = false

return nil
})
Expand Down
Loading
Loading