Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

@DiogoSantoss DiogoSantoss commented Jan 21, 2026

Fix double eager timer by using genesis time instead of wall clock.

category: bug
ticket: #4241

@DiogoSantoss DiogoSantoss self-assigned this Jan 21, 2026
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.94%. Comparing base (fcb8c34) to head (76a5fb5).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
core/consensus/timer/roundtimer.go 36.36% 19 Missing and 2 partials ⚠️
core/consensus/qbft/qbft.go 42.85% 2 Missing and 2 partials ⚠️
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4243      +/-   ##
==========================================
- Coverage   57.03%   56.94%   -0.09%     
==========================================
  Files         237      237              
  Lines       30857    30892      +35     
==========================================
- Hits        17599    17592       -7     
- Misses      11021    11055      +34     
- Partials     2237     2245       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DiogoSantoss DiogoSantoss added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 22, 2026
@obol-bulldozer obol-bulldozer bot merged commit 31ff299 into main Jan 22, 2026
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the diogo/fix-eager-timer branch January 22, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants