Fix cert validation become for remote_src certificates#100
Merged
Conversation
When elasticsearch_tls_remote_src is true, certificate files live on the remote host and may require elevated privileges to read (e.g. FreeIPA certs in /etc/pki). The validation tasks previously hardcoded become: false, causing permission denied errors. Now become is set dynamically based on _validate_remote_src — local certs are validated without privilege escalation, remote certs use become as expected. Replaces #97 (rebased on current main).
Commit b10dc0c changed the Kibana extra_config rendering from verbatim output to to_nice_yaml, which works for dict values but wraps strings in quotes — producing invalid YAML like 'elasticsearch.ssl.verificationMode: none' instead of a proper key-value line. The template now checks if the value is a mapping (dict) and uses to_nice_yaml only in that case, falling back to verbatim output for strings. This was causing all kibana_custom and kibana_custom_certs molecule scenarios to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When elasticsearch_tls_remote_src is true, certificate files live on the remote host and may need elevated privileges to read (e.g. FreeIPA-managed certs in /etc/pki). The validation tasks previously hardcoded become: false, causing permission denied errors on stat, openssl, and grep operations.
This sets become dynamically based on _validate_remote_src — local certs are still validated without privilege escalation, remote certs use become as expected.
Replaces #97 (rebased on current main).