Clean up pass-through variables and standardize defaults#90
Merged
Conversation
…e defaults
Remove elasticsearch_action_destructive_requires_name, elasticsearch_recovery_max_bytes_per_sec,
and the five elasticsearch_http_cors_* variables — these were pure pass-through to elasticsearch.yml
with no role-side behavior. Users should set them via elasticsearch_extra_config instead.
Extract the _elasticsearch_managed_keys list (used by both the template filter and the conflict
warning task) into vars/main.yml so it's defined once. Add elasticsearch_extra_config: {} as an
explicit default. Mark kibana_sniff_on_start and kibana_sniff_on_connection_fault as deprecated
(removed in 9.x). Change kibana_config_backup default from true to false to match ES and Logstash.
Fix beats version guard (> 7 to >= 8). Document why elasticsearch_manage_logging defaults to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elasticsearch_action_destructive_requires_name,elasticsearch_recovery_max_bytes_per_sec, and the 5elasticsearch_http_cors_*settings) — these had no role-side behavior and should go throughelasticsearch_extra_configinstead_elasticsearch_managed_keyslist intovars/main.yml(was duplicated in both the template and the conflict warning task)elasticsearch_extra_config: {}default with documentationkibana_sniff_on_startandkibana_sniff_on_connection_faultas deprecated (removed in 9.x)kibana_config_backupdefault fromtruetofalse(matches ES and Logstash)> 7→>= 8)elasticsearch_manage_loggingdefaults tofalseextra_configTest plan
elasticsearch_customscenario passes (validates extra_config pass-through renders correctly)elasticsearch_defaultscenario passes (validates cluster_settings still works)