Create Kibana certificate directory unconditionally#99
Closed
Conversation
The /etc/kibana/certs directory is needed for both Kibana TLS and ES connection CA certificates. Previously it was only created inside the kibana_tls block, so deployments with ES TLS but without Kibana TLS would fail. Move directory creation before the conditional.
Owner
Author
|
Not needed — the directory is already created unconditionally at line 127 of kibana-security.yml, outside the kibana_tls block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /etc/kibana/certs directory is needed for both Kibana TLS and ES connection CA certificates. Previously it was only created inside the kibana_tls block, so deployments with elasticsearch_http_security enabled but kibana_tls disabled would fail because the directory didn't exist yet.
This moves directory creation before the kibana_tls conditional so it's always present when the external certificate block runs.
Replaces #98 (rebased on current main).