Fix search suggestions ignoring selected region (#139)#140
Merged
aaronbrethorst merged 3 commits intomainfrom Jan 19, 2026
Merged
Fix search suggestions ignoring selected region (#139)#140aaronbrethorst merged 3 commits intomainfrom
aaronbrethorst merged 3 commits intomainfrom
Conversation
- Add required searchRegion property to OTPConfiguration - Create SwiftUI environment key for search region propagation - Update SearchManager to accept region in init and use MKLocalSearchCompleter.regionPriority = .required (iOS 18+) - Update SearchSheetView to read region from environment - Update tests, previews, demo app, and documentation
aaronbrethorst
force-pushed
the
constrain-search-region
branch
2 times, most recently
from
f456983 to
acdce00
Compare
* Update GitHub CI Xcode version to 26.2 * Fix xcresult path in CI workflow * Manually create simulator and use iPhone 16 Pro with iOS 26.2
aaronbrethorst
force-pushed
the
constrain-search-region
branch
from
acdce00 to
f7d20bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MKCoordinateRegion(.world)searchRegionproperty toOTPConfigurationMKLocalSearchCompleter.regionPriority = .required(iOS 18+) to strictly enforce results come only from the specified regionChanges
searchRegion: MKCoordinateRegionproperty and SwiftUI environment keyregionPriority = .requiredTest plan