Add explicit "Leave At" time to Trip Planner results#144
Conversation
aaronbrethorst
left a comment
There was a problem hiding this comment.
hi thanks for your contribution!
- change to "Depart:" and "Arrive:"
- Make both times
.medium - Use localization keys or at least update the the string tables with empty placeholders
|
Thanks for the feedback. I made the following changes:
|
aaronbrethorst
left a comment
There was a problem hiding this comment.
nice work @diveshpatil9104!
|
@diveshpatil9104 tests are failing :( |
|
I noticed that too. I checked the logs and the failures are in TripPlannerViewModelTests, which I didn't modify in this PR. 🥲Since this seems to be a pre-existing issue unrelated to the UI changes.. |
|
@diveshpatil9104 duly noted! |
|
@aaronbrethorst Thanks for the quick merge!
|

Summary
This PR updates the
TripPlannerResultslist to explicitly display the Departure Time ("Leave at") for each itinerary option. Previously, users only saw the Duration and Arrival Time (ETA), forcing them to do mental math to figure out when to leave the house.Changes
ItineraryPreviewView.swiftHStackto displayLeave at: [startTime] • Arrive: [endTime].Screenshots