Fix flaky TripPlannerViewModel async tests#145
Merged
aaronbrethorst merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
Replace fixed Task.sleep(0.2s) calls with a polling helper function that waits for isLoading to become false with a 5-second timeout. The fixed sleep duration was insufficient on slower CI machines, causing intermittent test failures for: - planTrip succeeds with valid locations - planTrip sets loading state correctly - planTrip handles API errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent CI test failures in
TripPlannerViewModelTeststhat have been affecting all recent builds on the main branch.Root Cause
The async tests were using a fixed
Task.sleep(nanoseconds: 200_000_000)(0.2 seconds) to wait for async operations to complete. This duration is insufficient on slower CI machines, causing tests to check assertions before the async operations finish.Changes
waitForLoadingComplete()helper function that pollsviewModel.isLoadingevery 50ms with a 5-second timeoutTests Fixed
planTrip succeeds with valid locationsplanTrip sets loading state correctlyplanTrip handles API errorsplanTrip clears previous errorsplanTrip uses wheelchair accessible settingplanTrip uses maxWalkDistance settingplanTrip uses arriveBy when timePreference is arriveByplanTrip uses leaveNow time preferenceTest plan