feat: add scroll-guard module, resetToBuiltInBundle API, and bump to 1.1.38#33
Open
huhuanming wants to merge 14 commits intomainfrom
Open
feat: add scroll-guard module, resetToBuiltInBundle API, and bump to 1.1.38#33huhuanming wants to merge 14 commits intomainfrom
huhuanming wants to merge 14 commits intomainfrom
Conversation
Add resetToBuiltInBundle() method to clear currentBundleVersion preference, allowing the app to revert to the built-in JS bundle on next restart. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Native view component that prevents parent PagerView from intercepting child ScrollView gestures. Uses requireGestureRecognizerToFail on iOS and requestDisallowInterceptTouchEvent on Android. Supports horizontal, vertical, and both directions. Includes example test page.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
- Nitro host views render React children as native siblings, not subviews. Override hitTest to return nil (pass-through) and find sibling ScrollView. - Use two-layer blocking: touch detector (LongPress with 0 delay) disables pager on touch-down instantly; blocker pan + require(toFail:) as backup. - Disable bounces on example banner ScrollView to prevent edge scroll leak. - Add homepage field to package.json for podspec validation. - Persist blocker across pager page transitions to avoid first-touch delay.
Remove 476 auto-generated nitrogen files from git tracking across all modules. Add nitrogen/ ignore rule to pager-view, scroll-guard, and tab-view .gitignore files. Also simplify scroll-guard .gitignore.
…roid HybridScrollGuardManager (generated by nitrogen) extends SimpleViewManager which doesn't implement IViewGroupManager, causing a ClassCastException when React Native tries to add child views. Replace with a custom ScrollGuardViewGroupManager that extends ViewGroupManager to properly support containing child scrollable views. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
huhuanming
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetToBuiltInBundle()API to react-native-bundle-update that clears thecurrentBundleVersionpreference, allowing the app to revert to the built-in JS bundle on next restartreact-native-scroll-guardmodule — a native view wrapper that prevents parent scrollable containers (PagerView/ViewPager2) from intercepting child scroll gesturesViewGroupManagerinstead of nitrogen-generatedSimpleViewManagerto properly support child views (fixesIViewGroupManagerClassCastException)Test plan
resetToBuiltInBundle()clears the bundle preference on Android and iOSresetToBuiltInBundle()and restarting🤖 Generated with Claude Code