Replace assert with proper null checks for content in write method#110
Open
Isurunwg wants to merge 37 commits intoOneLiteFeatherNET:masterfrom
Open
Replace assert with proper null checks for content in write method#110Isurunwg wants to merge 37 commits intoOneLiteFeatherNET:masterfrom
Isurunwg wants to merge 37 commits intoOneLiteFeatherNET:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces several important changes across multiple methods by replacing assert statements with proper runtime validation and handling.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
This PR significantly enhances the runtime behavior by ensuring that important checks are always performed, even when assertions are disabled. The code is now more resilient to edge cases and potential errors and will give more informative feedback when things go wrong.