Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 494e6d4e56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
NOTICE
Outdated
| Bundled third-party code under vendor/whisper-rs-sys retains its upstream | ||
| MIT licenses. See vendor/whisper-rs-sys/LICENSE and |
There was a problem hiding this comment.
Correct vendor license statement in NOTICE
The updated notice says all bundled code under vendor/whisper-rs-sys is MIT, but the vendored tree contains additional license markers (for example ggml-sycl/* files include SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception, and cmake/FindFFmpeg.cmake references BSD terms). Shipping an MIT-only statement can misstate redistribution obligations and break downstream license-compliance checks, so this line should be revised to enumerate or reference all applicable third-party licenses.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Reworded the vendor licensing note to stop claiming vendor/whisper-rs-sys is MIT-only. NOTICE now points to the vendor LICENSE, whisper.cpp/LICENSE, the Apache-2.0 WITH LLVM-exception headers under whisper.cpp/ggml/include and whisper.cpp/ggml/src/ggml-sycl, and the BSD notice in whisper.cpp/cmake/FindFFmpeg.cmake. I also updated the README to match.
Summary
whisper-rs-sysfork metadata to MIT and add an explicit vendor MIT license fileVerification
cargo metadata --no-deps --format-version 1cargo metadata --manifest-path vendor/whisper-rs-sys/Cargo.toml --no-deps --format-version 1cargo package --allow-dirty --no-verify --listcargo package --manifest-path vendor/whisper-rs-sys/Cargo.toml --allow-dirty --no-verify --list