Skip to content

chore: switch project license to MIT#4

Merged
OneNoted merged 2 commits intomainfrom
license-mit
Mar 19, 2026
Merged

chore: switch project license to MIT#4
OneNoted merged 2 commits intomainfrom
license-mit

Conversation

@OneNoted
Copy link
Owner

Summary

  • switch the project license text and manifest metadata to MIT
  • add root crate author metadata and update license docs/notices
  • change the vendored whisper-rs-sys fork metadata to MIT and add an explicit vendor MIT license file

Verification

  • cargo metadata --no-deps --format-version 1
  • cargo metadata --manifest-path vendor/whisper-rs-sys/Cargo.toml --no-deps --format-version 1
  • cargo package --allow-dirty --no-verify --list
  • cargo package --manifest-path vendor/whisper-rs-sys/Cargo.toml --allow-dirty --no-verify --list
  • repo-wide scan for stale MPL/Unlicense references

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 494e6d4e56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NOTICE Outdated
Comment on lines +4 to +5
Bundled third-party code under vendor/whisper-rs-sys retains its upstream
MIT licenses. See vendor/whisper-rs-sys/LICENSE and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Correct vendor license statement in NOTICE

The updated notice says all bundled code under vendor/whisper-rs-sys is MIT, but the vendored tree contains additional license markers (for example ggml-sycl/* files include SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception, and cmake/FindFFmpeg.cmake references BSD terms). Shipping an MIT-only statement can misstate redistribution obligations and break downstream license-compliance checks, so this line should be revised to enumerate or reference all applicable third-party licenses.

Useful? React with 👍 / 👎.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded the vendor licensing note to stop claiming vendor/whisper-rs-sys is MIT-only. NOTICE now points to the vendor LICENSE, whisper.cpp/LICENSE, the Apache-2.0 WITH LLVM-exception headers under whisper.cpp/ggml/include and whisper.cpp/ggml/src/ggml-sycl, and the BSD notice in whisper.cpp/cmake/FindFFmpeg.cmake. I also updated the README to match.

@OneNoted OneNoted merged commit d51d1f8 into main Mar 19, 2026
2 checks passed
@OneNoted OneNoted deleted the license-mit branch March 19, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant