Skip to content

chore: Release 1.0.4#22

Merged
fadi-george merged 2 commits into
mainfrom
rel/1.0.4
May 15, 2026
Merged

chore: Release 1.0.4#22
fadi-george merged 2 commits into
mainfrom
rel/1.0.4

Conversation

@onesignal-deploy
Copy link
Copy Markdown
Collaborator

Channels: Current

🐛 Bug Fixes

@onesignal-deploy onesignal-deploy requested a review from a team May 14, 2026 21:47
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - mechanical release bump (version + sdkVersion strings) with regenerated docgen output.

Extended reasoning...

Overview

This PR releases v1.0.4. Changes are limited to: package.json version bump (1.0.3 → 1.0.4), sdkVersion string constants in the Android Kotlin plugin and iOS Swift plugin ("010003" → "010004"), and regenerated docgen output in README.md (formatting/whitespace differences only — no API surface changes). The actual bug fixes referenced in the description (#20, #21) were merged in earlier PRs.

Security risks

None. No changes to auth, crypto, permissions, input validation, or any logic paths. The sdkVersion string is a telemetry tag forwarded to OneSignalWrapper.

Level of scrutiny

Minimal scrutiny appropriate. This is a textbook release commit: three version-string updates and a docgen regeneration. The pattern matches the prior 1.0.3 release commit (4a1def4).

Other factors

No bugs were flagged by the bug hunting system. The README diff is large in line count but is entirely auto-generated formatting drift from @capacitor/docgen (e.g., -----------------------, bullet style -*, extra blank lines between sections). The two SDK version constants are kept in sync between Android and iOS, as expected.

@fadi-george fadi-george merged commit eedffdf into main May 15, 2026
10 checks passed
@fadi-george fadi-george deleted the rel/1.0.4 branch May 15, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants