chore: [SDK-4194] add no-location Flutter demo#1158
Merged
Conversation
Keep the normalized ONESIGNAL_DISABLE_LOCATION parser from the parent branch and remove the stale exact-match block from the demo branch. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
force-pushed
the
fadi/sdk-4194-demo-no-location
branch
from
June 9, 2026 23:38
c0509a2 to
c0dcf64
Compare
Match the main Flutter demo by loading ONESIGNAL_APP_ID from a local .env file instead of requiring a dart-define for the no-location example. Co-authored-by: Cursor <cursoragent@cursor.com>
Add a small run.sh wrapper that exports ONESIGNAL_DISABLE_LOCATION for Flutter runs and update the no-location demo README to use it. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@claude review once |
Make the README explicitly call out setting ONESIGNAL_APP_ID in the demo .env file. Co-authored-by: Cursor <cursoragent@cursor.com>
Add the Runner entitlements file with aps-environment and wire it into the iOS app target so the no-location demo has the same push capability setup as the React Native demo. Co-authored-by: Cursor <cursoragent@cursor.com>
sherwinski
approved these changes
Jun 10, 2026
Update the no-location demo to detect the lowercase .env placeholder and point users to ONESIGNAL_APP_ID in .env instead of dart-define. Co-authored-by: Cursor <cursoragent@cursor.com>
nan-li
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds a minimal Flutter
demo-no-locationapp stacked on the SDK-4194 location-module opt-out work.iOS:
Android:
Details
Motivation
Some apps use OneSignal push and in-app messages without
OneSignal.Location. This demo provides a small runnable app for validating that push still works when the native OneSignal location module is excluded.Scope
examples/demo-no-locationwith minimal Flutter UI and native iOS/Android projects.ONESIGNAL_DISABLE_LOCATION=true.fadi/sdk-4194.Testing
Manual testing
ONESIGNAL_DISABLE_LOCATION=1 swift package dump-packageexcludesOneSignalLocation.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor