Skip to content

fix: update release PR native SDK version handling #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 2 commits into from
Jun 18, 2026
Merged

fix: update release PR native SDK version handling #1162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbbcff3
ci: fix android version regex in release PR
fadi-george Jun 18, 2026
2f7b1dd
ci: fix iOS version regex in release PR
fadi-george Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/create-release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ jobs:

# Get versions from target branch (not the release branch)
CURRENT_VERSION=$(git show origin/${{ inputs.target_branch }}:pubspec.yaml | grep "^version:" | sed 's/version: //' | tr -d ' ')
ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | sed -n "s/.*com\.onesignal:OneSignal:\([^']*\)'.*/\1/p")
IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:ios/onesignal_flutter.podspec | sed -n "s/.*OneSignalXCFramework', '\([^']*\)'.*/\1/p")
ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | sed -n "s/^def oneSignalVersion = ['\"]\([^'\"]*\)['\"].*/\1/p")
IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:ios/onesignal_flutter.podspec | sed -n "s/^[[:space:]]*onesignal_xcframework_version = ['\"]\([^'\"]*\)['\"].*/\1/p")

echo "flutter_from=$CURRENT_VERSION" >> $GITHUB_OUTPUT
echo "android_from=$ANDROID_VERSION" >> $GITHUB_OUTPUT
Expand All @@ -109,7 +109,7 @@ jobs:

# Update build.gradle with new version
# macOS sed syntax
sed -i '' "s|implementation 'com\.onesignal:OneSignal:[^']*'|implementation 'com.onesignal:OneSignal:${VERSION}'|" android/build.gradle
sed -i '' -E "s|^def oneSignalVersion = ['\"][^'\"]*['\"]|def oneSignalVersion = '${VERSION}'|" android/build.gradle
echo "✓ Updated android/build.gradle with Android SDK ${VERSION}"

# Only commit if there are changes
Expand All @@ -133,7 +133,7 @@ jobs:

# Update onesignal_flutter.podspec with new version
# macOS sed syntax
sed -i '' "s|s.dependency 'OneSignalXCFramework', '[^']*'|s.dependency 'OneSignalXCFramework', '${VERSION}'|" ios/onesignal_flutter.podspec
sed -i '' -E "s|^([[:space:]]*onesignal_xcframework_version = )['\"][^'\"]*['\"]|\\1'${VERSION}'|" ios/onesignal_flutter.podspec
echo "✓ Updated ios/onesignal_flutter.podspec with iOS SDK ${VERSION}"

# Update Package.swift with new version
Expand Down