Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
## Description

<!-- Please, provide a brief description of the changes you've made in this pull request. -->

## Related Issues

<!-- Links to related issues, fixed issues or partially addressed by this PR. -->

## Changes

<!-- List the main changes or features introduced by this PR -->

## Screenshots (if applicable)

<!-- Add any relevant screenshots or GIFs to showcase the changes visually -->

## Checklist

- [ ] I have tested these changes thoroughly.
- [ ] My code follows the project's coding style.
- [ ] I have added appropriate comments to my code, especially in complex areas.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
`graphdb.auth.security.enabled` property, which prevents users from disabling security via the
Workbench or REST API.
- Added encryption at rest configuration
- Added `publishNotReadyAddresses` to `service`, `headlessService`, `proxy.service` and `proxy.headlessService`.
Headless services default to `true` to allow cluster nodes to communicate before readiness probes pass,
enabling proper startup sequencing during rolling upgrades.


## Version 12.4.0
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,7 @@ IMPORTANT: This is generated by helm-docs, do not attempt modifying it on hand a
| headlessService.labels | object | `{}` | |
| headlessService.ports.http | int | `7200` | |
| headlessService.ports.rpc | int | `7300` | |
| headlessService.publishNotReadyAddresses | bool | `true` | |
| image.digest | string | `""` | |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.pullSecrets | list | `[]` | |
Expand Down Expand Up @@ -557,6 +558,7 @@ IMPORTANT: This is generated by helm-docs, do not attempt modifying it on hand a
| proxy.headlessService.labels | object | `{}` | |
| proxy.headlessService.ports.http | int | `7200` | |
| proxy.headlessService.ports.rpc | int | `7300` | |
| proxy.headlessService.publishNotReadyAddresses | bool | `true` | |
| proxy.initContainerDataPermissions.enabled | bool | `false` | |
| proxy.initContainerDataPermissions.securityContext.runAsNonRoot | bool | `false` | |
| proxy.initContainerDataPermissions.securityContext.runAsUser | int | `0` | |
Expand Down Expand Up @@ -625,6 +627,7 @@ IMPORTANT: This is generated by helm-docs, do not attempt modifying it on hand a
| proxy.service.loadBalancerSourceRanges | list | `[]` | |
| proxy.service.nodePort | string | `""` | |
| proxy.service.ports.http | int | `7200` | |
| proxy.service.publishNotReadyAddresses | bool | `false` | |
| proxy.service.type | string | `"ClusterIP"` | |
| proxy.startupProbe.failureThreshold | int | `120` | |
| proxy.startupProbe.httpGet.path | string | `"/proxy/ready"` | |
Expand Down Expand Up @@ -672,6 +675,7 @@ IMPORTANT: This is generated by helm-docs, do not attempt modifying it on hand a
| service.loadBalancerSourceRanges | list | `[]` | |
| service.nodePort | string | `""` | |
| service.ports.http | int | `7200` | |
| service.publishNotReadyAddresses | bool | `false` | |
| service.type | string | `"ClusterIP"` | |
| serviceAccount.annotations | object | `{}` | |
| serviceAccount.create | bool | `false` | |
Expand Down
1 change: 1 addition & 0 deletions templates/graphdb/service-headless.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ metadata:
{{- end }}
spec:
clusterIP: None
publishNotReadyAddresses: {{ .Values.headlessService.publishNotReadyAddresses }}
selector:
{{- include "graphdb.selectorLabels" . | nindent 4 }}
ports:
Expand Down
1 change: 1 addition & 0 deletions templates/graphdb/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
publishNotReadyAddresses: {{ .Values.service.publishNotReadyAddresses }}
selector:
{{- include "graphdb.selectorLabels" . | nindent 4 }}
{{- if .Values.service.externalTrafficPolicy }}
Expand Down
1 change: 1 addition & 0 deletions templates/proxy/service-headless.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ metadata:
{{- end }}
spec:
clusterIP: None
publishNotReadyAddresses: {{ .Values.proxy.headlessService.publishNotReadyAddresses }}
selector:
{{- include "graphdb-proxy.selectorLabels" . | nindent 4 }}
ports:
Expand Down
1 change: 1 addition & 0 deletions templates/proxy/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ metadata:
{{- end }}
spec:
type: {{ .Values.proxy.service.type }}
publishNotReadyAddresses: {{ .Values.proxy.service.publishNotReadyAddresses }}
selector:
{{- include "graphdb-proxy.selectorLabels" . | nindent 4 }}
{{- if .Values.proxy.service.externalTrafficPolicy }}
Expand Down
11 changes: 11 additions & 0 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,8 @@ service:
externalIPs: []
# Additional ports to expose with the Service.
extraPorts: []
# Indicates that DNS records are created for not-ready Pods.
publishNotReadyAddresses: false

# Configurations for GraphDB headless Service.
# This Service is deployed regardless of the amount of .Values.replicas, so it exists for both single node and for cluster mode.
Expand All @@ -701,6 +703,9 @@ headlessService:
rpc: 7300
# Additional ports to expose with the Service.
extraPorts: []
# Indicates that DNS records are created for not-ready Pods.
# Enabled so cluster nodes can communicate before readiness probes pass, allowing proper startup sequencing during rolling upgrades.
publishNotReadyAddresses: true

##############################
# Persistence Configurations #
Expand Down Expand Up @@ -1418,6 +1423,8 @@ proxy:
externalIPs: []
# Additional proxy ports to expose with the Service.
extraPorts: []
# Indicates that DNS records are created for not-ready Pods.
publishNotReadyAddresses: false

# GraphDB cluster proxy headless Service configurations.
# Ref: https://kubernetes.io/docs/concepts/services-networking/service/
Expand All @@ -1439,6 +1446,10 @@ proxy:
rpc: 7300
# Additional proxy ports to expose with the Service.
extraPorts: []
# Indicates that DNS records are created for not-ready Pods.
# Enabled so cluster nodes can communicate before readiness probes pass, allowing proper startup sequencing during rolling upgrades.
# Ref: https://kubernetes.io/docs/concepts/services-networking/service/#publishnotreadyaddresses
publishNotReadyAddresses: true

##############################
# Persistence Configurations #
Expand Down