GDB-14762: Fix query abort handling#3004
Open
boyan-tonchev wants to merge 1 commit into
Open
Conversation
boyan-tonchev
force-pushed
the
GDB-14762-fix-query-aborting-on-logout
branch
2 times, most recently
from
3ec2efd to
beec066
Compare
## What When the Logout action was triggered while a query was executing, the application started the logout process immediately. This caused the header and sidebar to disappear before the user confirmed the action. Additionally, the running query was not aborted correctly. ## Why There was no mechanism to prevent event execution once an action was triggered. As a result, events such as Logout were emitted immediately, even when additional confirmation or asynchronous processing was required before executing the action. ## How Extended the EventService subscription mechanism with optional cancellation handlers. Before an event is emitted, all registered cancellation handlers are evaluated. If any handler requests cancellation, the event is not emitted and the associated action is not executed. Implemented cancellation handlers for query-related actions in the SPARQL editor. These handlers display the running query confirmation dialog, abort the running query when the user confirms the action, and prevent the action when the user cancels it. ## Additional work Fixes Operations links to open views in a new tab.
boyan-tonchev
force-pushed
the
GDB-14762-fix-query-aborting-on-logout
branch
from
beec066 to
451f0a3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the Logout action was triggered while a query was executing, the application started the logout process immediately. This caused the header and sidebar to disappear before the user confirmed the action. Additionally, the running query was not aborted correctly.
Why
There was no mechanism to prevent event execution once an action was triggered. As a result, events such as Logout were emitted immediately, even when additional confirmation or asynchronous processing was required before executing the action.
How
Extended the EventService subscription mechanism with optional cancellation handlers.
Before an event is emitted, all registered cancellation handlers are evaluated. If any handler requests cancellation, the event is not emitted and the associated action is not executed.
Implemented cancellation handlers for query-related actions in the SPARQL editor. These handlers display the running query confirmation dialog, abort the running query when the user confirms the action, and prevent the action when the user cancels it.
Additional work
Fixes Operations links to open views in a new tab.
Checklist