Add programmatic plan security validator tests#137
Open
JSv4 wants to merge 1 commit intofeat/plan-security-cancellation-validationfrom
Open
Add programmatic plan security validator tests#137JSv4 wants to merge 1 commit intofeat/plan-security-cancellation-validationfrom
JSv4 wants to merge 1 commit intofeat/plan-security-cancellation-validationfrom
Conversation
JSv4
force-pushed
the
feat/plan-security-cancellation-validation
branch
from
f08ea07 to
0b9d5d3
Compare
14 tests covering plan security issuance, acceptance, retraction, and cancellation validators: - Valid and invalid issuance (stakeholder, stock plan, board approval, pool) - Pool adjustment and return-to-pool restoring capacity - Multiple independent pools tracked correctly - Acceptance blocked by prior retraction - Retraction blocked by prior acceptance - Cancellation with and without conflicting transactions Also allows TX_STOCK_PLAN_RETURN_TO_POOL as a companion transaction in the cancellation validator, since cancellation + return to pool is a natural pair in the OCF lifecycle.
JSv4
force-pushed
the
feat/plan-security-validator-tests
branch
from
51486b4 to
03681b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
PR 6/6 — top of the stack, based on #135 (cancellation)
Test plan