Remove vesting schedule generators and ISO calculator#142
Open
MattCantor wants to merge 3 commits intoOpen-Cap-Table-Coalition:mainfrom
Open
Remove vesting schedule generators and ISO calculator#142MattCantor wants to merge 3 commits intoOpen-Cap-Table-Coalition:mainfrom
MattCantor wants to merge 3 commits intoOpen-Cap-Table-Coalition:mainfrom
Conversation
3 tasks
These modules are being extracted to their own repo. Restores root types/ with only the types needed by read_ocf_package, removes unused dependencies (date-fns, fraction.js, mermaid), and cleans up testing scripts and package.json entries that referenced the deleted code.
MattCantor
force-pushed
the
remove-vesting-generators
branch
from
f4903a2 to
1753752
Compare
MattCantor
requested review from
JSv4 and
arthur-clara
and removed request for
JSv4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vesting_schedule_generator/,vesting_schedule_generator_v1/, andiso_nso_calculator/read_ocf_packagetypes import to point to the new roottypes/directory (was previously pointing to the now-deletedvesting_schedule_generator_v1/types)date-fns,fraction.js,mermaid)package.jsonscripts andjest.config.jsreferences to deleted modulesWhat remains
ocf_validator/— XState-based transaction validatorocf_snapshot/— point-in-time cap table snapshotsread_ocf_package/— OCF package readertypes/— shared OCF type definitions (pruned to only what's used)Test plan
npx tsc --noEmitcompiles cleanlyocfValidatoragainst both sample OCF packages — both validate successfully