Import from right module#404
Conversation
These symbols are not exported from where they are imported, so update the code to import from the right place.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 83.35% 83.36% +0.01%
==========================================
Files 39 39
Lines 2601 2603 +2
==========================================
+ Hits 2168 2170 +2
Misses 433 433 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| import dask | ||
| import dask.array as da | ||
| import numpy as np | ||
| from dask.delayed import delayed |
There was a problem hiding this comment.
Shouldn't it be: from dask import delayed ? See https://github.com/dask/dask/blob/e237122a298a00b6091712d83d77c00e94bf30fc/dask/delayed.py#L460
There was a problem hiding this comment.
Well, the Pyright author disagrees about exports: microsoft/pyright#2639 (comment)
I haven't read all the relevant standards so I can't comment on this issue, but my experience is that he's usually right on a technical level (and he tends to be balanced, so he's working within the system when some specification is saying crazy things).
From a practical perspective, Pylance is using Pyright under the hood, so every VSCode user will get squiggly lines under these symbols.
2 participants
These symbols are not exported
from where they are imported,
so update the code to import
from the right place.