Conversation
…other processes. Default to numerical index instead of string. (#478)
* `filter_spatial`: Clarified that a masking get applied for the given geometries. #469 * `filter_bbox`: Clarified that the bounding box is reprojected to the CRS of the spatial data cube dimensions if required. --------- Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
Member
Author
|
Just confirmed that's it. I will cross reference them later then as they need to be in my working repo too. |
soxofaan
reviewed
Dec 6, 2023
soxofaan
reviewed
Dec 7, 2023
m-mohr
requested changes
Dec 8, 2023
Member
There was a problem hiding this comment.
@PondiB I think it would make sense to make PRs against the ml branch because otherwise all changes from the ML branch will also appear in this PR. This leads to confusion. Please rebase your changes against the ML branch if necessary and set the base branch of the PR to ml.
Member
Author
Sure, noted |
PondiB
changed the title
Member
Author
|
Closing this in favor of #492 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #441 , Support Vector Classification