Skip to content

Add protocol connection profile schema#221

Merged
smithaldon1 merged 1 commit into
mainfrom
feat/issue-207-connection-profile-schema
May 23, 2026
Merged

Add protocol connection profile schema#221
smithaldon1 merged 1 commit into
mainfrom
feat/issue-207-connection-profile-schema

Conversation

@smithaldon1
Copy link
Copy Markdown
Member

Closes #207

Summary

  • Add ProtocolConnectionProfile to the shared factory_events contracts package for OPC-UA, MQTT, and BACnet profiles.
  • Define common profile metadata, enabled state, endpoint/address, acquisition settings, mapping reference, health state, timestamps, and protocol-specific config blocks.
  • Require secret and certificate references instead of raw values, validate protocol/config combinations, and add fixtures for all three protocols.

Test Evidence

  • .venv/bin/python -m pytest packages/factory-events/tests/test_connection_profile_contracts.py - passed, 10 tests.
  • make test-contract - passed, 76 tests.
  • make test - passed, 223 tests.
  • make lint - passed.
  • make typecheck - passed.
  • make docs - passed placeholder docs target: "Docs are Markdown-only in the MVP skeleton; no docs checker is configured yet."
  • git diff --check and git diff --cached --check - passed.

Docs Impact

  • Updated docs/DATA_CONTRACTS.md with the connection profile contract.
  • Updated packages/factory-events/README.md.
  • Updated docs/LEARNING_LOG.md.

Follow-up Work

Copy link
Copy Markdown
Member Author

@smithaldon1 smithaldon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved for merge

@smithaldon1 smithaldon1 merged commit 7270a55 into main May 23, 2026
3 checks passed
@smithaldon1 smithaldon1 deleted the feat/issue-207-connection-profile-schema branch May 23, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2. Feature: Define protocol connection profile schema

1 participant